[FIX] room data is not erased after deleting rooms by app #27886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuonghuunguyen
changed the title
cuonghuunguyen
force-pushed
the
fix-delete-room-by-app
branch
from
d4721c6 to
8e4c363
Compare
debdutdeb
changed the title
Member
|
could you please solve the conflict ? |
cuonghuunguyen
dismissed stale reviews from AlenDavid, thassiov, and debdutdeb
via
3daa84e
cuonghuunguyen
force-pushed
the
fix-delete-room-by-app
branch
from
8e4c363 to
3daa84e
Compare
cuonghuunguyen
force-pushed
the
fix-delete-room-by-app
branch
from
3daa84e to
d8a1d68
Compare
Contributor
Author
|
Done |
Member
|
could you please synchronize with develop again? it should not fail more |
Contributor
Author
|
Could u do me a favor?
Vào 2:45 SA, Th 4, 8 thg 3, 2023 Guilherme Gazzo ***@***.***>
đã viết:
… could you please synchronize with develop again? it should not fail more
btw there is any reason you blocked changes on your fork? if not I could
update by myself
—
Reply to this email directly, view it on GitHub
<#27886 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHAAS52GR3XPMCP2N3QBBQ3W26F5JANCNFSM6AAAAAAUK5NRY4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
debdutdeb
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Currently only the room is removed when we delete the room by Apps.
After this PR, we will remove all of the related data of the room when removing it by Apps Engine
Issue(s)
Steps to test or reproduce
Further comments