Skip to content

Regression: Custom fields form not showing in user profile nor admin #27244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 4 commits into from
Nov 17, 2022
Merged

Regression: Custom fields form not showing in user profile nor admin #27244

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
930e15b
remove default value from component
gabriellsh Nov 11, 2022
9820f7e
Merge branch 'develop' into fix/customFieldsForm
gabriellsh Nov 14, 2022
bccaf85
Merge branch 'develop' into fix/customFieldsForm
kodiakhq[bot] Nov 17, 2022
9c0324b
Merge branch 'develop' into fix/customFieldsForm
kodiakhq[bot] Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions apps/meteor/client/components/CustomFieldsForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,13 +112,7 @@ const CustomFieldsAssembler = ({ formValues, formHandlers, customFields, ...prop
return null;
});

export default function CustomFieldsForm({
jsonCustomFields = {},
customFieldsData,
setCustomFieldsData,
onLoadFields = () => {},
...props
}) {
export default function CustomFieldsForm({ jsonCustomFields, customFieldsData, setCustomFieldsData, onLoadFields = () => {}, ...props }) {
const accountsCustomFieldsJson = useSetting('Accounts_CustomFields');

const [customFields] = useState(() => {
Expand Down
2 changes: 1 addition & 1 deletion apps/meteor/client/views/account/profile/AccountProfileForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ const AccountProfileForm = ({ values, handlers, user, settings, onSaveStateChang
</Grid.Item>
</Grid>
</Field>
<CustomFieldsForm customFieldsData={customFields} setCustomFieldsData={handleCustomFields} />
<CustomFieldsForm jsonCustomFields={undefined} customFieldsData={customFields} setCustomFieldsData={handleCustomFields} />
</FieldGroup>
);
};
Expand Down