Skip to content

Conversation

@matheusbsilva137
Copy link
Contributor

@matheusbsilva137 matheusbsilva137 commented Oct 14, 2022

Proposed changes (including videos or screenshots)

  • Improvement: add read receipts for messages in threads only when the thread is open;
  • Move read-receipts feature to EE (under the message-read-receipt module). The chat.getMessageReadReceipts endpoint and getReadReceipts Meteor method are now EE only.

Issue(s)

Steps to test or reproduce

Further comments

TC-73

@matheusbsilva137 matheusbsilva137 requested a review from a team as a code owner October 14, 2022 19:09
@matheusbsilva137 matheusbsilva137 marked this pull request as draft October 14, 2022 19:10
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #27074 (2418212) into develop (88f7024) will increase coverage by 1.18%.
The diff coverage is 75.00%.

❗ Current head 2418212 differs from pull request most recent head 5dc4c05. Consider uploading reports for the commit 5dc4c05 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27074      +/-   ##
===========================================
+ Coverage    42.24%   43.43%   +1.18%     
===========================================
  Files          812      787      -25     
  Lines        16052    15560     -492     
  Branches      2072     1999      -73     
===========================================
- Hits          6781     6758      -23     
+ Misses        8991     8520     -471     
- Partials       280      282       +2     
Flag Coverage Δ
e2e 43.43% <75.00%> (+1.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 added this to the 6.0.0 milestone Jan 4, 2023
@outofrange
Copy link

outofrange commented Feb 1, 2023

Since I just stumbled over this, and haven't found any other info about Move read-receipts feature to EE - does this mean read notifications, those little check marks to the right of each message, a very useful feature, will be removed from the upcoming Community Edition?

@ggazzo ggazzo merged commit e9667ed into develop Feb 14, 2023
@ggazzo ggazzo deleted the fix-threads-read-receipts branch February 14, 2023 23:16
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
@ghost
Copy link

ghost commented Mar 11, 2023

Please see this forum post regarding this change:
https://forums.rocket.chat/t/update-6-0-0-read-receipts-complaint/16164/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

squad: team-collab stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.