Skip to content

[FIX] Room Avatar being deleted after upload. #27060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 4 commits into from
Nov 1, 2022
Merged

[FIX] Room Avatar being deleted after upload. #27060

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a684ef
Delete before update
gabriellsh Oct 13, 2022
63bb05e
Fix etag and convert to TS
gabriellsh Oct 19, 2022
5d8b153
Fix TS
gabriellsh Oct 20, 2022
3444493
Merge branch 'develop' into fix/s3Avatar
kodiakhq[bot] Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions apps/meteor/app/lib/server/functions/setRoomAvatar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,16 @@ export const setRoomAvatar = async function (rid: string, dataURI: string, user:
uid: user._id,
};

if (current) {
fileStore.deleteById(current._id);
}

fileStore.insert(file, buffer, (err: unknown, result: { etag: string }) => {
if (err) {
throw err;
}

Meteor.setTimeout(function () {
if (current) {
fileStore.deleteById(current._id);
}
Rooms.setAvatarData(rid, 'upload', result.etag);
Messages.createRoomSettingsChangedWithTypeRoomIdMessageAndUser('room_changed_avatar', rid, '', user);
api.broadcast('room.avatarUpdate', { _id: rid, avatarETag: result.etag });
Expand Down