Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposed initial poc 'benchmark' ui - #115 #264

Merged
merged 1 commit into from
Jul 6, 2015
Merged

proposed initial poc 'benchmark' ui - #115 #264

merged 1 commit into from
Jul 6, 2015

Conversation

Sing-Li
Copy link
Member

@Sing-Li Sing-Li commented Jul 6, 2015

non-intrusive implementation, no impact to rest of UI when web-rtc video is not in session

ONLY when web-rtc video is showing, click on the remote-video window to switch modes

HELP please ... (need experts) TODOS:

  • the ugly {{#if}} in room.html needs to be refactored into one single set of <div><video>, perhaps some template helpers, and CSS3 transition added to make boxes 'fly into place'

engelgabriel added a commit that referenced this pull request Jul 6, 2015
proposed initial poc 'benchmark' ui - #115
@engelgabriel engelgabriel merged commit a049db2 into RocketChat:master Jul 6, 2015
@Sing-Li Sing-Li deleted the webrtc-bmark-ui branch July 9, 2015 01:41
Peym4n pushed a commit to redlink-gmbh/Rocket.Chat that referenced this pull request Mar 19, 2018
…istics

Travis fails in an unrelated place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants