Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Message Forwarding Section Two #26265

Merged
merged 8 commits into from
Aug 23, 2022
Merged

[NEW] Message Forwarding Section Two #26265

merged 8 commits into from
Aug 23, 2022

Conversation

nishant23122000
Copy link
Contributor

@nishant23122000 nishant23122000 commented Jul 14, 2022 •
edited
Loading

Proposed changes (including videos or screenshots)

This PR contains some major functionality which is the backbone of this feature

  1. Added Tab Component to toggle between the Preview and Editor section.

Screenshot 2022-07-14 at 8 20 45 PM

  1. Added share message functionality by using chat.postMessage API route.
  2. Added logic to preview only image files inside the share message modal.

Screenshot 2022-07-14 at 8 21 11 PM

Issue(s)

Steps to test or reproduce

Further comments

@nishant23122000 nishant23122000 requested a review from a team as a code owner July 14, 2022 14:53
@nishant23122000 nishant23122000 requested review from a team as code owners July 25, 2022 13:15
@dougfabris dougfabris merged commit 4ac455a into RocketChat:new/message-forwarding Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougfabris dougfabris dougfabris requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nishant23122000 @dougfabris