Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Fix micro services #26054

Merged
merged 3 commits into from
Jun 29, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions apps/meteor/definition/externals/meteor/meteor.d.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,17 @@
/* eslint-disable @typescript-eslint/interface-name-prefix */
import 'meteor/meteor';
import { IStreamerConstructor, IStreamer } from 'meteor/rocketchat:streamer';

declare module 'meteor/meteor' {
namespace Meteor {
const Streamer: IStreamerConstructor & IStreamer;

namespace StreamerCentral {
const instances: {
[name: string]: IStreamer;
};
}

interface ErrorStatic {
new (error: string | number, reason?: string, details?: any): Error;
}
Expand Down
14 changes: 0 additions & 14 deletions apps/meteor/definition/externals/meteor/rocketchat-streamer.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,17 +80,3 @@ declare module 'meteor/rocketchat:streamer' {
new (name: string, options?: { retransmit?: boolean; retransmitToSelf?: boolean }): IStreamer;
}
}

declare module 'meteor/meteor' {
import { IStreamerConstructor, IStreamer } from 'meteor/rocketchat:streamer';

namespace Meteor {
const Streamer: IStreamerConstructor & IStreamer;

namespace StreamerCentral {
const instances: {
[name: string]: IStreamer;
};
}
}
}
1 change: 0 additions & 1 deletion apps/meteor/ee/server/services/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
"pm2": "pm2",
"start:account": "ts-node --files ./account/service.ts",
"start:authorization": "ts-node --files ./authorization/service.ts",
"start:ddp-streamer": "ts-node --files ./ddp-streamer/service.ts",
"start:presence": "ts-node --files ./presence/service.ts",
"start:stream-hub": "ts-node --files ./stream-hub/service.ts",
"typecheck": "tsc --noEmit --skipLibCheck",
Expand Down
2 changes: 1 addition & 1 deletion apps/meteor/ee/server/services/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@
// "emitDecoratorMetadata": true,
// "experimentalDecorators": true,
},
"include": ["./**/*", "../../../definition"],
"include": ["./**/*", "../../../definition/externals/meteor/rocketchat-streamer.d.ts"],
"exclude": ["./dist", "./ecosystem.config.js", "../../../definition/methods"]
}
2 changes: 1 addition & 1 deletion apps/meteor/server/modules/listeners/listeners.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { parse } from '@rocket.chat/message-parser';
import { IServiceClass } from '../../sdk/types/ServiceClass';
import { NotificationsModule } from '../notifications/notifications.module';
import { EnterpriseSettings } from '../../sdk/index';
import { settings } from '../../../app/settings/server';
import { settings } from '../../../app/settings/server/cached';

const isMessageParserDisabled = process.env.DISABLE_MESSAGE_PARSER === 'true';

Expand Down
2 changes: 1 addition & 1 deletion apps/meteor/server/services/voip/lib/Helper.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { ServerType, IVoipManagementServerConfig, IVoipCallServerConfig } from '@rocket.chat/core-typings';

import { settings } from '../../../../app/settings/server';
import { settings } from '../../../../app/settings/server/cached';

export function getServerConfigDataFromSettings(type: ServerType): IVoipCallServerConfig | IVoipManagementServerConfig {
switch (type) {
Expand Down
3 changes: 2 additions & 1 deletion ee/apps/ddp-streamer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"description": "Rocket.Chat DDP-Streamer service",
"scripts": {
"build": "tsc -p tsconfig.json",
"test": "echo \"Error: no test specified\" && exit 1"
"test": "echo \"Error: no test specified\" && exit 1",
"typecheck": "tsc --noEmit --skipLibCheck -p tsconfig.json"
},
"keywords": [
"rocketchat"
Expand Down
2 changes: 1 addition & 1 deletion ee/apps/ddp-streamer/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"declaration": false,
"declarationMap": false
},
"include": ["./src/**/*", "../../../apps/meteor/definition", "./definition"],
"include": ["./src/**/*", "./definition", "../../../apps/meteor/definition/externals/meteor/rocketchat-streamer.d.ts"],
"exclude": ["./dist", "./ecosystem.config.js"]
}