Skip to content

Chore: refactor/tsc-perf #26040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 2, 2022
Merged

Chore: refactor/tsc-perf #26040

merged 9 commits into from
Jul 2, 2022

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo added this to the 5.0.0 milestone Jul 1, 2022
@tassoevan tassoevan force-pushed the refactor/tsc-perf branch from 1eb54e1 to d98b590 Compare July 1, 2022 18:38
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 1, 2022
View reviewed changes
apps/meteor/ee/server/services/ecdh-proxy/lib/server.ts
@@ -104,7 +104,7 @@
publicKeyString: session.publicKeyString,
});
} catch (e) {
res.status(400).send(e.message);
res.status(400).send(e instanceof Error ? e.message : String(e));

Check warning

Code scanning / CodeQL

Exception text reinterpreted as HTML

[Exception text](1) is reinterpreted as HTML without escaping meta-characters. [Exception text](2) is reinterpreted as HTML without escaping meta-characters.
apps/meteor/ee/server/services/ecdh-proxy/lib/server.ts
@@ -124,7 +124,7 @@
res.send(await session.encrypt(result));
} catch (e) {
console.error(e);
res.status(400).send(e.message);
res.status(400).send(e instanceof Error ? e.message : String(e));

Check warning

Code scanning / CodeQL

Exception text reinterpreted as HTML

[Exception text](1) is reinterpreted as HTML without escaping meta-characters.
apps/meteor/ee/server/services/ecdh-proxy/lib/server.ts
@@ -193,7 +193,7 @@
try {
proxy(req, res, session);
} catch (e) {
res.status(400).send(e.message);
res.status(400).send(e instanceof Error ? e.message : String(e));

Check warning

Code scanning / CodeQL

Exception text reinterpreted as HTML

[Exception text](1) is reinterpreted as HTML without escaping meta-characters.
apps/meteor/ee/server/services/ecdh-proxy/lib/server.ts
@@ -229,7 +229,7 @@
try {
proxy(req, res, session, xhrDataRequestProcess, xhrDataResponseProcess);
} catch (e) {
res.status(400).send(e.message);
res.status(400).send(e instanceof Error ? e.message : String(e));

Check warning

Code scanning / CodeQL

Exception text reinterpreted as HTML

[Exception text](1) is reinterpreted as HTML without escaping meta-characters.
apps/meteor/ee/server/services/ecdh-proxy/lib/server.ts
@@ -245,7 +245,7 @@
try {
proxy(req, res, session, undefined, xhrDataResponseProcess);
} catch (e) {
res.status(400).send(e.message);
res.status(400).send(e instanceof Error ? e.message : String(e));

Check warning

Code scanning / CodeQL

Exception text reinterpreted as HTML

[Exception text](1) is reinterpreted as HTML without escaping meta-characters.
apps/meteor/ee/server/services/ecdh-proxy/lib/server.ts
@@ -104,7 +104,7 @@
publicKeyString: session.publicKeyString,
});
} catch (e) {
res.status(400).send(e.message);
res.status(400).send(e instanceof Error ? e.message : String(e));

Check warning

Code scanning / CodeQL

Information exposure through a stack trace

Stack trace information from [here](1) may be exposed to an external user here.
apps/meteor/ee/server/services/ecdh-proxy/lib/server.ts
@@ -124,7 +124,7 @@
res.send(await session.encrypt(result));
} catch (e) {
console.error(e);
res.status(400).send(e.message);
res.status(400).send(e instanceof Error ? e.message : String(e));

Check warning

Code scanning / CodeQL

Information exposure through a stack trace

Stack trace information from [here](1) may be exposed to an external user here.
apps/meteor/ee/server/services/ecdh-proxy/lib/server.ts
@@ -193,7 +193,7 @@
try {
proxy(req, res, session);
} catch (e) {
res.status(400).send(e.message);
res.status(400).send(e instanceof Error ? e.message : String(e));

Check warning

Code scanning / CodeQL

Information exposure through a stack trace

Stack trace information from [here](1) may be exposed to an external user here.
apps/meteor/ee/server/services/ecdh-proxy/lib/server.ts
@@ -229,7 +229,7 @@
try {
proxy(req, res, session, xhrDataRequestProcess, xhrDataResponseProcess);
} catch (e) {
res.status(400).send(e.message);
res.status(400).send(e instanceof Error ? e.message : String(e));

Check warning

Code scanning / CodeQL

Information exposure through a stack trace

Stack trace information from [here](1) may be exposed to an external user here.
apps/meteor/ee/server/services/ecdh-proxy/lib/server.ts
@@ -245,7 +245,7 @@
try {
proxy(req, res, session, undefined, xhrDataResponseProcess);
} catch (e) {
res.status(400).send(e.message);
res.status(400).send(e instanceof Error ? e.message : String(e));

Check warning

Code scanning / CodeQL

Information exposure through a stack trace

Stack trace information from [here](1) may be exposed to an external user here.
@lgtm-com
Copy link

lgtm-com bot commented Jul 1, 2022

This pull request introduces 5 alerts when merging d98b590 into 26c310c - view on LGTM.com

new alerts:

  • 5 for Information exposure through a stack trace

@tassoevan tassoevan force-pushed the refactor/tsc-perf branch from d98b590 to 92a8323 Compare July 1, 2022 19:05
@lgtm-com
Copy link

lgtm-com bot commented Jul 1, 2022

This pull request introduces 5 alerts when merging 92a8323 into 3394c0d - view on LGTM.com

new alerts:

  • 5 for Information exposure through a stack trace

@tassoevan tassoevan force-pushed the refactor/tsc-perf branch from 92a8323 to a56230e Compare July 1, 2022 19:31
@lgtm-com
Copy link

lgtm-com bot commented Jul 1, 2022

This pull request introduces 5 alerts when merging a56230e into 3394c0d - view on LGTM.com

new alerts:

  • 5 for Information exposure through a stack trace

@lgtm-com
Copy link

lgtm-com bot commented Jul 1, 2022

This pull request introduces 5 alerts when merging cf08a10 into bef0b2d - view on LGTM.com

new alerts:

  • 5 for Information exposure through a stack trace

@tassoevan tassoevan force-pushed the refactor/tsc-perf branch from cf08a10 to c321587 Compare July 2, 2022 00:48
@lgtm-com
Copy link

lgtm-com bot commented Jul 2, 2022

This pull request introduces 5 alerts when merging c321587 into 58e32cf - view on LGTM.com

new alerts:

  • 5 for Information exposure through a stack trace

@lgtm-com
Copy link

lgtm-com bot commented Jul 2, 2022

This pull request introduces 5 alerts when merging 96c9017 into 0bc25a0 - view on LGTM.com

new alerts:

  • 5 for Information exposure through a stack trace

@lgtm-com
Copy link

lgtm-com bot commented Jul 2, 2022

This pull request introduces 5 alerts when merging 6d0b620 into 4d99ef0 - view on LGTM.com

new alerts:

  • 5 for Information exposure through a stack trace

@ggazzo ggazzo marked this pull request as ready for review July 2, 2022 02:40
@ggazzo ggazzo requested review from a team as code owners July 2, 2022 02:40
@lgtm-com
Copy link

lgtm-com bot commented Jul 2, 2022

This pull request introduces 5 alerts when merging 2a0e6ae into 4d99ef0 - view on LGTM.com

new alerts:

  • 5 for Information exposure through a stack trace

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Jul 2, 2022
@ggazzo ggazzo merged commit 3427e5e into develop Jul 2, 2022
@ggazzo ggazzo deleted the refactor/tsc-perf branch July 2, 2022 03:22
@lgtm-com
Copy link

lgtm-com bot commented Jul 2, 2022

This pull request introduces 5 alerts when merging 16894df into 12c1cf6 - view on LGTM.com

new alerts:

  • 5 for Information exposure through a stack trace

gabriellsh added a commit that referenced this pull request Jul 4, 2022
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into scroll
61c0b6d 
* 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits)
  Chore: move fork of cas module to the monorepo (#26107)
  Chore: Add Agenda fork to the monorepo (#25681)
  Chore: Bump deps (#25624)
  [NEW][ENTERPRISE] Device Management (#25791)
  Chore: `refactor/tsc-perf` (#26040)
  [BREAK] Upgrade to version 5.0 can be done only from version 4.x (#26100)
  [BREAK] Remove support to old MongoDB versions (#26098)
  [NEW] Matrix Federation UX improvements (#25847)
  Regression: en.i18n.json spaces
  [NEW][ENTERPRISE] Introducing dial pad component into sidebar, calls table, contextual bar (#26081)
  Chore: Settings UI issue (#26053)
  Chore: Adding default message parser template (#26064)
  Regression: [VideoConference] If the caller loses connection, direct calls are never canceled (#26099)
  Chore: Handle errors on index creation (#26094)
  Chore: fix watermark condition (#26095)
  [FIX] Validate room access (#24534)
  [BREAK] VideoConference (#25570)
  [FIX] Undefined headers on API Client (#26083)
  Regression: Add Error boundary to katex render component (#26067)
  Chore: Allow endpoints to optionally require authentication (#26084)
  ...
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tassoevan @ggazzo @pierre-lehnen-rc