Regression: Non-reactive routes #25990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
approved these changes
Jun 23, 2022
github-actions
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jun 27, 2022
…turbo * 'develop' of github.com:RocketChat/Rocket.Chat: (42 commits) Chore: Major refactors in pageobjects (#26015) [BREAK] Remove show message in main thread preference (#26002) Regression: Webhook Integration Creation + string error toast msg (#26008) Chore: convert e2e to ts (#25958) Regression: Room Endpoint Call Issues (#25928) Chore: Fixes e2e playwright intermittences (#25984) Chore: Fuselage update (#26004) Chore: Small fix on callProvider (#25963) [FIX] Initial members value on Create Channel Modal (#26000) Chore: Migrate from meteor model to raw (#25756) Chore: VoIP Context (#25994) Chore: Fuselage update (#25983) [FIX] sidebar colors (#25987) Regression: Non-reactive routes (#25990) [BREAK] use urlParams on omnichannel/agent/extension/ (#25982) [FIX] toolbox menu behind thread component (#25925) [FIX] Sort by scope or creation date not working on canned responses list (#25475) Chore: Colors (#25969) Revert "[BREAK] use urlParams on omnichannel/agent/extension/" (#25980) Regression: Prevent Form Submit on Reset Click ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
When
Tracker.autorun()calls are nested, it's possible that an invalidation at the parent render the children non-reactive due to synchronous calls. To avoid that under the callback given byuseSyncExternalStore, we schedule anonStoreChangecallback call to not make it reside at the same backtrace.Issue(s)
Steps to test or reproduce
Further comments