Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: RestApiClient as Package #25469

Merged
merged 52 commits into from
Jun 8, 2022
Merged

Chore: RestApiClient as Package #25469

merged 52 commits into from
Jun 8, 2022

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented May 11, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo changed the title wip Chore: RestApiClient as Package May 11, 2022
@lgtm-com
Copy link

lgtm-com bot commented May 11, 2022

This pull request introduces 2 alerts when merging d4a5881 into 54a3887 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@ggazzo ggazzo force-pushed the chore/api-client branch from 0cc27a9 to ad17d15 Compare May 13, 2022 14:07
@lgtm-com
Copy link

lgtm-com bot commented May 17, 2022

This pull request introduces 1 alert when merging cf411eb into 86c0131 - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

@lgtm-com
Copy link

lgtm-com bot commented May 17, 2022

This pull request introduces 1 alert when merging 5585356 into 86c0131 - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

@ggazzo ggazzo force-pushed the chore/api-client branch from 6aa5505 to 07efe9f Compare May 17, 2022 21:32
@ggazzo ggazzo force-pushed the chore/api-client branch from 07efe9f to 6f9909e Compare May 17, 2022 21:37
@ggazzo ggazzo force-pushed the chore/api-client branch from 1cc46f2 to eb952fb Compare May 18, 2022 02:18
@RocketChat RocketChat deleted a comment from lgtm-com bot May 18, 2022
apps/meteor/app/api/server/v1/settings.ts Outdated Show resolved Hide resolved
apps/meteor/app/api/server/v1/settings.ts Outdated Show resolved Hide resolved
apps/meteor/app/api/server/v1/settings.ts Outdated Show resolved Hide resolved
apps/meteor/app/api/server/v1/settings.ts Outdated Show resolved Hide resolved
apps/meteor/app/api/server/v1/settings.ts Outdated Show resolved Hide resolved
packages/api-client/src/index.ts Show resolved Hide resolved
apps/meteor/client/lib/presence.ts Show resolved Hide resolved
@ggazzo ggazzo added the eng day label May 20, 2022
@ggazzo ggazzo force-pushed the chore/api-client branch from c551e69 to 58fd89a Compare May 28, 2022 04:20
@ggazzo ggazzo requested a review from a team as a code owner June 8, 2022 04:32
@ggazzo ggazzo force-pushed the chore/api-client branch from baed8f5 to 4e11d16 Compare June 8, 2022 04:36
Copy link
Member

@d-gubert d-gubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on the Apps side

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Jun 8, 2022
@kodiakhq kodiakhq bot merged commit 611c0b3 into develop Jun 8, 2022
@kodiakhq kodiakhq bot deleted the chore/api-client branch June 8, 2022 19:06
gabriellsh added a commit that referenced this pull request Jun 10, 2022
…e/split-useUserInfoActions

* 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits)
  Regression: Fix apps wrong typing (#25824)
  Chore: Remove compose from main repo (#23426)
  [FIX] `You and @Yourusername reacted with`title on reactions (#25733)
  [FIX] AgentsPage pagination (#25820)
  Chore: Move voip's Wrap-up and On-hold functionality to EE (Backend) (#25160)
  [FIX] Access issue on chat.getThreadsList (#25750)
  Chore: Remove snap files from Houston config (#25819)
  [FIX] Voip endpoint permissions (#25783)
  [FIX] allow only livechat-agents to be contact manager for any omnichannel contact  (#25451)
  Chore: use params instead of URL building on livechat endpoints (#25810)
  Regression: fix apps path (#25809)
  [BREAK] Remove RDStation integration (#25774)
  Chore: RestApiClient as Package (#25469)
  [FIX] Wrong argument name preventing Omnichannel Chat Forward to User  (#25723)
  [FIX] AccountBox checks for condition (#25708)
  Chore: Fix CI (#25797)
  [FIX] Fix prom-client new promise usage (#25781)
  [FIX] Discussion alphabetical  ordering (#25788)
  Update .kodiak.toml
  Update .kodiak.toml
  ...
gabriellsh added a commit that referenced this pull request Jun 13, 2022
…homepage

* 'develop' of github.com:RocketChat/Rocket.Chat: (21 commits)
  [FIX] Client-generated sort parameters in channel directory  (#25768)
  Chore: Add tests for agents screens (#25637)
  Chore: Notification Preferences to TS (#25827)
  Chore: Convert MemoizedSetting, Setting, Section (#25572)
  Regression: Fix users.create call (#25834)
  Chore: Add auto label and improve Kodiak configuration (#25829)
  Regression: Fix apps wrong typing (#25824)
  Chore: Remove compose from main repo (#23426)
  [FIX] `You and @Yourusername reacted with`title on reactions (#25733)
  [FIX] AgentsPage pagination (#25820)
  Chore: Move voip's Wrap-up and On-hold functionality to EE (Backend) (#25160)
  [FIX] Access issue on chat.getThreadsList (#25750)
  Chore: Remove snap files from Houston config (#25819)
  [FIX] Voip endpoint permissions (#25783)
  [FIX] allow only livechat-agents to be contact manager for any omnichannel contact  (#25451)
  Chore: use params instead of URL building on livechat endpoints (#25810)
  Regression: fix apps path (#25809)
  [BREAK] Remove RDStation integration (#25774)
  Chore: RestApiClient as Package (#25469)
  [FIX] Wrong argument name preventing Omnichannel Chat Forward to User  (#25723)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng day stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants