Chore: Tests with Playwright (task: ROC-66, Intermittent resolution in tests) #25416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souzaramon
reviewed
May 9, 2022
| @@ -43,7 +43,7 @@ const AnnouncementComponent: FC<AnnouncementComponentParams> = ({ children, onCl | |||
| textAlign='center' | |||
| className={announcementBar} | |||
| > | |||
| <Box withTruncatedText w='none'> | |||
| <Box withTruncatedText w='none' data-qa={`AnnouncementAnnoucementComponent`}> | |||
There was a problem hiding this comment.
Remove unnecessary template string
souzaramon
reviewed
May 9, 2022
| @@ -103,7 +103,7 @@ function UserInfo({ | |||
| {name && ( | |||
| <InfoPanel.Field> | |||
| <InfoPanel.Label>{t('Full_Name')}</InfoPanel.Label> | |||
| <InfoPanel.Text>{name}</InfoPanel.Text> | |||
| <InfoPanel.Text data-qa='UserName'>{name}</InfoPanel.Text> | |||
There was a problem hiding this comment.
data-qa should be UserInfoUserName
souzaramon
reviewed
May 9, 2022
apps/meteor/out.txt
Outdated
| @@ -0,0 +1 @@ | |||
| 09-channel--Channel-Usage-Channel-settings-Cha-b9b9c-ncement-edit-expect-edit-the-announcement-input | |||
There was a problem hiding this comment.
add out.txt to .gitignore and remove this file
souzaramon
reviewed
May 9, 2022
| const mongoBaseUrl = process.env.MONGO_URL | ||
| ? `${process.env.MONGO_URL}?retryWrites=false` | ||
| : 'mongodb://localhost:3001/meteor?retryWrites=false'; | ||
| export const clearMessage = async (channelIds: string[]): Promise<void> => { |
There was a problem hiding this comment.
should be clearMessages, and the file should be equal as well
souzaramon
suggested changes
May 9, 2022
ggazzo
reviewed
May 9, 2022
| @@ -43,7 +43,7 @@ const AnnouncementComponent: FC<AnnouncementComponentParams> = ({ children, onCl | |||
| textAlign='center' | |||
| className={announcementBar} | |||
| > | |||
| <Box withTruncatedText w='none'> | |||
| <Box withTruncatedText w='none' data-qa={`AnnouncementAnnoucementComponent`}> | |||
There was a problem hiding this comment.
Suggested change
| <Box withTruncatedText w='none' data-qa={`AnnouncementAnnoucementComponent`}> | |
| <Box withTruncatedText w='none' data-qa='AnnouncementAnnoucementComponent'> |
souzaramon
reviewed
May 10, 2022
| @@ -43,7 +43,7 @@ const AnnouncementComponent: FC<AnnouncementComponentParams> = ({ children, onCl | |||
| textAlign='center' | |||
| className={announcementBar} | |||
| > | |||
| <Box withTruncatedText w='none'> | |||
| <Box withTruncatedText w='none' data-qa={'AnnouncementAnnoucementComponent'}> | |||
There was a problem hiding this comment.
Suggested change
| <Box withTruncatedText w='none' data-qa={'AnnouncementAnnoucementComponent'}> | |
| <Box withTruncatedText w='none' data-qa='AnnouncementAnnoucementComponent'> |
souzaramon
pushed a commit
that referenced
this pull request
May 11, 2022
…n tests) (#25416) Co-authored-by: Ramon Souza <[email protected]>
gabriellsh
added a commit
that referenced
this pull request
May 12, 2022
…lists * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Move markdown message parser to a `callback` (#25413) [FIX] Settings listeners not receiving overwritten values from env vars (#25448) Chore: Move ddp-streamer micro service to its own sub-repo (#25246) [NEW] Use setting to determine if initial general channel is needed (#25441) [IMPROVE] New admin settings Page (#25439) [FIX] Failure to update Integration History index (#25473) Chore: Rewrite 2fa to typescript (#25285) Chore: solve yarn issues from env var (#25468) Chore: REST query and body params validation (#25446) Chore: Tests with Playwright (task: ROC-66, Intermittent resolution in tests) (#25416) Chore: Convert email inbox feature to TypeScript (#25298)
gabriellsh
added a commit
that referenced
this pull request
May 16, 2022
* 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Migrate NotFoundPage to TS (#25509) [FIX] Unable to see channel member list by authorized channel roles (#25412) Regression: Fix services-image-build-check (#25519) Chore: Migrate spotify to ts (#25507) [Chore] Reorder unreleased migrations (#25508) [FIX] Spotlight results showing usernames instead of real names (#25471) [FIX] LDAP sync removing users from channels when multiple groups are mapped to it (#25434) Chore: Move markdown message parser to a `callback` (#25413) [FIX] Settings listeners not receiving overwritten values from env vars (#25448) Chore: Move ddp-streamer micro service to its own sub-repo (#25246) [NEW] Use setting to determine if initial general channel is needed (#25441) [IMPROVE] New admin settings Page (#25439) [FIX] Failure to update Integration History index (#25473) Chore: Rewrite 2fa to typescript (#25285) Chore: solve yarn issues from env var (#25468) Chore: REST query and body params validation (#25446) Chore: Tests with Playwright (task: ROC-66, Intermittent resolution in tests) (#25416) Chore: Convert email inbox feature to TypeScript (#25298)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments