Skip to content

Conversation

@Amit91848
Copy link
Contributor

Proposed changes (including videos or screenshots)

Fixed typo when discussion modal opens. Now it says - Help keep an overview of what's going on!

Screenshot 2022-03-29 at 6 59 45 PM

Issue(s)

Steps to test or reproduce

Further comments

@CLAassistant
Copy link

CLAassistant commented Mar 29, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dougfabris
❌ “Amit91848”


“Amit91848” seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@debdutdeb
Copy link
Member

@Amit91848 please sign the CLA.

@Amit91848
Copy link
Contributor Author

Screenshot 2022-03-29 at 9 17 19 PM

I have already signed the cla. But somehow it keeps on showing pending!?

@Kunalvrm555
Copy link
Contributor

Please make sure that you are using the same GitHub account for signing the CLA and for opening a pull request.
@Amit91848

@Amit91848
Copy link
Contributor Author

Yes, I checked multiple times, I am using the same account

ggazzo
ggazzo previously approved these changes Nov 24, 2022
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Dec 22, 2022
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #24982 (1fa5d7b) into develop (be41f2a) will increase coverage by 2.19%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #24982      +/-   ##
===========================================
+ Coverage    40.52%   42.71%   +2.19%     
===========================================
  Files          844      839       -5     
  Lines        17910    17707     -203     
  Branches      1988     1977      -11     
===========================================
+ Hits          7258     7564     +306     
+ Misses       10396     9889     -507     
+ Partials       256      254       -2     
Flag Coverage Δ
e2e 42.71% <80.00%> (+2.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit 9372d8e into RocketChat:develop Dec 22, 2022
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants