[IMPROVE] Play selected notification sounds as preview while changing sound settings #24205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…changing the volume
Contributor
Author
|
@dougfabris @sampaiodiego Can you please take a look ? |
NakulRaghav
previously approved these changes
Feb 10, 2022
Contributor
|
Amazing work.🔥 |
Contributor
Author
|
@debdutdeb Can you please take a look at this again as it is open for a while now and haven't got any updates on it? |
|
Is this PR still actual for the community? |
ggazzo
approved these changes
Feb 14, 2023
dionisio-bot
bot
added
stat: ready to merge
Codecov Report
@@ Coverage Diff @@
## develop #24205 +/- ##
============================================
+ Coverage 32.32% 43.72% +11.39%
============================================
Files 626 791 +165
Lines 12481 15392 +2911
Branches 1836 2131 +295
============================================
+ Hits 4035 6730 +2695
- Misses 8248 8375 +127
- Partials 198 287 +89
Flags with carried forward coverage won't be shown. Click here to find out more. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Currently no sound plays while changing the notification sound settings or adjusting the volume which does not seem to be a good user experience as the user cannot preview the changes.
This PR enables the user to listen the selected sound at the selected volume .
Check out this video for the proposed changes (Turn on the volume)
notification-sounds.mp4
Issue(s)
Steps to test or reproduce
Further comments