Implemented delete button next to edit and modal confirmation #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks again @rockhouse =D can you please add translations to confirm messages? the possibility for translation I mean. |
|
I've tested this and I got two things:
|
|
Both suggestions by @sampaiodiego have been implemented in SHA: f8e542e |
tkurz
pushed a commit
to redlink-gmbh/Rocket.Chat
that referenced
this pull request
Mar 13, 2018
…-separately' into port/0.61.1
tkurz
pushed a commit
to redlink-gmbh/Rocket.Chat
that referenced
this pull request
Mar 13, 2018
tkurz
pushed a commit
to redlink-gmbh/Rocket.Chat
that referenced
this pull request
Mar 13, 2018
…-run-tests-separately Run tests separately
HappyTobi
pushed a commit
to HappyTobi/Rocket.Chat
that referenced
this pull request
Jul 10, 2018
set "available" status from system idle time
This was referenced Jul 6, 2020
shubhsherl
pushed a commit
to shubhsherl/Rocket.Chat
that referenced
this pull request
Jul 21, 2020
Add pushm and pushm_encrypted to Message object
This was referenced Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once more as discussed with @sampaiodiego now adjusted to new message rendering
Link to old PR #189