Skip to content

Regression: Federation warnings on ci #22765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 1 commit into from
Jul 27, 2021
Merged

Regression: Federation warnings on ci #22765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions client/views/admin/info/FederationCard/components/FederationModal/FederationModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,15 +86,24 @@ export const FederationModal: FC<{ onClose: () => void }> = ({
} else {
setCurrentStep(currentStep + 1);
}
}, [currentStep, hasUnsavedChanges, domain, discoveryMethod]);
}, [
currentStep,
hasUnsavedChanges,
domain,
discoveryMethod,
commit,
onClose,
setFederationDomain,
setFederationDiscoveryMethod,
]);

const previousStep = useCallback(() => {
if (currentStep === 1) {
onClose();
} else {
setCurrentStep(currentStep - 1);
}
}, [currentStep]);
}, [currentStep, onClose]);

// Resolve DNS
const resolvedSRVString = useSetting('FEDERATION_ResolvedSRV') as string;
Expand Down Expand Up @@ -152,10 +161,10 @@ export const FederationModal: FC<{ onClose: () => void }> = ({
</Modal.Header>
<Modal.Content>
<Tabs>
<Tabs.Item selected={currentTab === 1} onClick={() => setCurrentTab(1)}>
<Tabs.Item selected={currentTab === 1} onClick={(): void => setCurrentTab(1)}>
Configure DNS
</Tabs.Item>
<Tabs.Item selected={currentTab === 2} onClick={() => setCurrentTab(2)}>
<Tabs.Item selected={currentTab === 2} onClick={(): void => setCurrentTab(2)}>
Legacy Support
</Tabs.Item>
</Tabs>
Expand Down