[FIX] Omnichannel/Twilio - When a file is sent as first message, chat is not queued #22590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murtaza98
reviewed
Jul 8, 2021
| console.error(`Attachment upload failed: ${ e.message }`); | ||
| attachment = { | ||
| fields: [{ | ||
| title: 'User upload failed', |
Contributor
There was a problem hiding this comment.
I think we should add translations for this. WDYT?
Member
Author
There was a problem hiding this comment.
I think it would be good 🤔 , what I think is that the FE won't translate message content, even if it looks like a translation string.
Contributor
There was a problem hiding this comment.
For translations we usually use this method which picks up the translations from the i18n folder. So earlier in my comment I was suggesting to add the translations within the translation files and modify this to something like
Suggested change
| title: 'User upload failed', | |
| title: t('sms_upload_failed'), |
Member
Author
There was a problem hiding this comment.
🤔 but that would add a dependency on meteor for the code, and I know the team collab team is trying to reduce meteor's usage.
Contributor
There was a problem hiding this comment.
ohh.. wasn't aware of this 😕 if that's the case, how are they proposing to handle the translations, any idea?
Member
Author
There was a problem hiding this comment.
Not actually as far as I know :(
murtaza98
reviewed
Jul 8, 2021
| attachment = { | ||
| fields: [{ | ||
| title: 'User upload failed', | ||
| value: 'An attachment was received, but upload to server failed', |
Contributor
There was a problem hiding this comment.
I think we should add translations for this. WDYT?
Contributor
|
Tested this PR and it fixes the issue we're facing earlier |
murtaza98
approved these changes
Jul 13, 2021
gabriellsh
added a commit
that referenced
this pull request
Jul 20, 2021
…improve/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listimprove/discussion-listMerge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/attachment_emoji * 'develop' of github.com:RocketChat/Rocket.Chat: (119 commits) [IMPROVE] Configuration for indices in Apps-Engine models (#22705) [FIX] Use room's last message time when visitor did not send any message (#22695) F room doesnt exists error when uploading file as first message (#22590) [IMPROVE] Refactor `livechat.registerGuest` function (#22684) change livechat_enabled default value to true (#22697) Chore: added pagination to search msg endpoint (#22632) Fixed crush in the getChannelHistory method (#22667) Regression: Fix ee microservices build (#22656) [IMPROVE] Rewrite sidebar footer as React Component (#22687) [FIX] Livechat config endpoint is not returning all settings (#22686) [FIX] Info page - Instances card modal table width #22627 Bump version to 3.16.3 fixed - room still listed after delete (#22613) Chore: Use projection instead of fields to avoid error log (#22629) [FIX] VisitorClientInfo not showing (#22593) Create README.md (#22615) [NEW] REST endpoint to remove User from Role (#20485) Bump version to 3.16.2 Regression: Change the name of called methods in Users model (#22620) [FIX] Markdown for UiKit blocks (#22619) ...
gabriellsh
added a commit
that referenced
this pull request
Jul 20, 2021
…status-message * 'develop' of github.com:RocketChat/Rocket.Chat: (114 commits) [FIX] Remove team's related actions inside of discussion #22470 [IMPROVE] Configuration for indices in Apps-Engine models (#22705) [FIX] Use room's last message time when visitor did not send any message (#22695) F room doesnt exists error when uploading file as first message (#22590) [IMPROVE] Refactor `livechat.registerGuest` function (#22684) change livechat_enabled default value to true (#22697) Chore: added pagination to search msg endpoint (#22632) Fixed crush in the getChannelHistory method (#22667) Regression: Fix ee microservices build (#22656) [IMPROVE] Rewrite sidebar footer as React Component (#22687) [FIX] Livechat config endpoint is not returning all settings (#22686) [FIX] Info page - Instances card modal table width #22627 Bump version to 3.16.3 fixed - room still listed after delete (#22613) Chore: Use projection instead of fields to avoid error log (#22629) [FIX] VisitorClientInfo not showing (#22593) Create README.md (#22615) [NEW] REST endpoint to remove User from Role (#20485) Bump version to 3.16.2 Regression: Change the name of called methods in Users model (#22620) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments