Skip to content

[FIX] Quote message not working for Livechat visitors #22586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevLehman merged 4 commits into from
Jul 29, 2021
Merged

[FIX] Quote message not working for Livechat visitors #22586

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3db00b9
Fix quote message not working for livechat visitors
murtaza98 Jul 6, 2021
e5fa53d
Apply suggestions from code review
murtaza98 Jul 28, 2021
d5d9fdf
Merge branch 'develop' into omnichannel/fix-visitor-quote-msg-1
KevLehman Jul 28, 2021
e12d6d2
Merge branch 'develop' into omnichannel/fix-visitor-quote-msg-1
KevLehman Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/oembed/server/jumpToMessage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ callbacks.add('beforeSaveMessage', (msg) => {
// validates if user can see the message
// user has to belong to the room the message was first wrote in
const room = Rooms.findOneById(jumpToMessage.rid);
const canAccessRoomForUser = canAccessRoom(room, currentUser);
const isLiveChatRoomVisitor = !!msg.token && !!room.v?.token && msg.token === room.v.token;
const canAccessRoomForUser = isLiveChatRoomVisitor || canAccessRoom(room, currentUser);
if (!canAccessRoomForUser) {
return;
}
Expand Down