Skip to content

[FIX] Checks the list of agents if at least one is online #22584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sampaiodiego merged 3 commits into from
Jul 7, 2021
Merged

[FIX] Checks the list of agents if at least one is online #22584

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7ab376
use $in into username
tiagoevanp Jul 5, 2021
1d09dcc
Merge branch 'develop' into fix/livechat-no-agents-online
tiagoevanp Jul 6, 2021
7c981df
Change method name
sampaiodiego Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/models/server/models/Users.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,11 @@ export class Users extends Base {
return this.findOne(query);
}

findOneOnlineAgentByUsername(username, options) { // TODO:: Create class Agent
findOneOnlineAgentByUsername(userList, options) { // TODO:: Create class Agent

@ggazzo ggazzo Jul 6, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rename or create a new method? "by username" doesn’t look complete compatible with 'usernamesList'

const username = {
$in: [].concat(userList),
};

const query = queryStatusAgentOnline({ username });

return this.findOne(query, options);
Expand Down