Regression: Enable unregistered servers to use their own push gateway #22391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucassartor
requested review from
a team and
KevLehman
and removed request for
KevLehman
sampaiodiego
requested changes
Jun 18, 2021
| _id: 'Push_enable', | ||
| value: true, | ||
| }, | ||
| { |
Member
There was a problem hiding this comment.
instead of removing this enable query, let's remove the enable query from the custom certificates settings (Push_apn_passphrase, Push_apn_key, etc.)
doing so, you can also revert the new setting description..
Contributor
Author
There was a problem hiding this comment.
Ok, did it! But with this change I had to modify one validation in server > lib > pushConfig.js, otherwise the custom certificates wouldn't work in unregistered servers.
Member
There was a problem hiding this comment.
thx @lucassartor I had to change to set an empty enableQuery because otherwise the previous value was still set
on DB: f633ca1
I also changed a little bit the logic the configurePush so it used the same logic in both places 3863792
sampaiodiego
approved these changes
Jun 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
#22346 prevented unregistered servers from using the RC push gateway but was still blocking this servers from using their own push gateway, this PR looks to fix that.
Issue(s)
Steps to test or reproduce
Further comments