Chore: Enforce TypeScript on Storybook #22317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougfabris
requested changes
Jun 11, 2021
| - name: Build Storybook to sanity check components | ||
| run: npm run build-storybook ; rm -rf ./storybook-static | ||
| env: | ||
| NODE_OPTIONS: --max_old_space_size=8192 |
Member
There was a problem hiding this comment.
We need all this memory to build the storybook? 4096 isn't enough?
Contributor
Author
There was a problem hiding this comment.
We need it (at least while we don't fix the typings issues I've cited), but this heap size is now set on the npm script. Take a look at "storybook" and "build-storybook" in package.json.
Member
There was a problem hiding this comment.
I mean, I had a memory issue to run the storybook I was thinking if it's necessary 8192 because I solve using 4096, doesn't affect the review, it's just for curiosity :P
Member
There was a problem hiding this comment.
Btw, we still have the issue with cookie and cookie-parser when trying to launch storybook 😞
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Rewrite some Storybook stories in TypeScript, as an example.
Issue(s)
Steps to test or reproduce
Further comments
It's important to note that Storybook's Webpack configuration is mixing
babel-loaderandts-loader. It unnecessarily increases memory usage and prevent us to rewrite a.storybook/main.tsbecause there are many suppressed TypeScript errors across the code.