Skip to content

[FIX] Permission check for teams.listRoomsOfUser #22313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pierre-lehnen-rc merged 2 commits into from
Jun 10, 2021
Merged

[FIX] Permission check for teams.listRoomsOfUser #22313

pierre-lehnen-rc merged 2 commits into from
Jun 10, 2021

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Jun 10, 2021

Proposed changes (including videos or screenshots)

If the user is trying to list his own channels, the permission check is skipped.

Issue(s)

Steps to test or reproduce

  • Try to leave a team with a user that has no privileges (eg. is not owner/leader nor admin)
  • The users joined channels should be displayed even if he does not has the view-all-team-channels permission.
    PS.: If the user has not joined any additional rooms inside the team, the first step of the modal is not displayed.

Further comments

@gabriellsh gabriellsh requested a review from a team June 10, 2021 18:42
@pierre-lehnen-rc pierre-lehnen-rc merged commit e8c6072 into develop Jun 10, 2021
@pierre-lehnen-rc pierre-lehnen-rc deleted the fix/list_rooms_permission branch June 10, 2021 22:46
@sampaiodiego sampaiodiego mentioned this pull request Jun 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierre-lehnen-rc pierre-lehnen-rc pierre-lehnen-rc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gabriellsh @pierre-lehnen-rc