Skip to content

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Jun 7, 2021

Proposed changes (including videos or screenshots)

Changed CSS so printed media from the auditing page includes all page content.

Issue(s)

Steps to test or reproduce

  • Go to auditing page
  • Select a date range and channel that has multiple pages of messages
  • Print
  • There should be multiple pages to be printed

Further comments

@gabriellsh gabriellsh requested a review from a team June 7, 2021 19:22
@tassoevan tassoevan added this to the 3.16.0 milestone Jun 8, 2021
Copy link
Contributor

@tassoevan tassoevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please justify the hack of using !important directives with some comments.

@dougfabris
Copy link
Member

@gabriellsh would be nice to have the steps to reproduce and info about what is changing

@tassoevan tassoevan merged commit 0327a20 into develop Jun 9, 2021
@tassoevan tassoevan deleted the fix/print_auditing branch June 9, 2021 19:51
@sampaiodiego sampaiodiego mentioned this pull request Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants