Skip to content

Conversation

@matheusbsilva137
Copy link
Contributor

Proposed changes (including videos or screenshots)

  • Add new teams.converToChannel endpoint;
  • Update ConvertToTeam modal text (since this action can now be reversed);
  • Remove corresponding team memberships when a team is deleted or converted to a channel;

Issue(s)

Task - ClickUp

Steps to test or reproduce

Example input (using cURL):

curl -H 'X-Auth-Token: q39ji2DgG_UHeM9gPfHmnnjLbdFHIatcxRKp50xnsMh' \
     -H 'X-User-Id: ZzdS98Atik353EbSM' \
     -H 'Content-Type: application/json' \
     http://localhost:3000/api/v1/teams.convertToChannel \
     -d '{ "teamId": "60b10af92f1caf38cae47708", "roomsToRemove": ["9uQTE87H8ZfdqNQMY"]}'

roomsToRemove is an array of strings (ids of the team rooms to be deleted when the team is converted to a channel).

Further comments

@matheusbsilva137 matheusbsilva137 requested a review from a team May 28, 2021 15:57
@pierre-lehnen-rc pierre-lehnen-rc merged commit 3ad7b11 into develop Jun 14, 2021
@pierre-lehnen-rc pierre-lehnen-rc deleted the teams-convert-to-channel branch June 14, 2021 18:55
@sampaiodiego sampaiodiego mentioned this pull request Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants