Skip to content

Conversation

@tiagoevanp
Copy link
Contributor

Proposed changes (including videos or screenshots)

image

Issue(s)

Steps to test or reproduce

Further comments

@ankar84
Copy link

ankar84 commented May 28, 2021

Great improvement for user experience!
Please consider my feature request related to that topic a bit RocketChat/Rocket.Chat.Electron#1487

@tiagoevanp tiagoevanp marked this pull request as ready for review June 3, 2021 05:53
@tiagoevanp tiagoevanp requested a review from MartinSchoeler June 3, 2021 05:54
Copy link
Member

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@MartinSchoeler MartinSchoeler merged commit 3748e28 into improve/canned-response Jun 15, 2021
@MartinSchoeler MartinSchoeler deleted the feat/text-editor branch June 15, 2021 19:42
MartinSchoeler pushed a commit that referenced this pull request Jul 19, 2021
* Include Insert_Placeholder key

* change emojiPicker z-index

* create TextEditor component

* create MarkdownTextEditor component

* update fuselage dev version

* update fuselage and react-types version

* finish MardownTextEditorComponent

* update fuselage package
MartinSchoeler pushed a commit that referenced this pull request Jul 19, 2021
* Include Insert_Placeholder key

* change emojiPicker z-index

* create TextEditor component

* create MarkdownTextEditor component

* update fuselage dev version

* update fuselage and react-types version

* finish MardownTextEditorComponent

* update fuselage package
KevLehman pushed a commit that referenced this pull request Jul 19, 2021
#22190)

* no results components to table with no data

* [IMPROVE][Enterprise] Create and Update CannedResponse API endpoints (#22151)

* createdBy query fix

* fix the canned-responses filter (#22207)

* [NEW] New components TextEditor and MarkdownTextEditor (#22173)

* Include Insert_Placeholder key

* change emojiPicker z-index

* create TextEditor component

* create MarkdownTextEditor component

* update fuselage dev version

* update fuselage and react-types version

* finish MardownTextEditorComponent

* update fuselage package

* [NEW][ENTERPRISE] Canned responses Overview Page (#22623)

* [NEW] Empty page for Canned Responses Table

* FIX LGTM

* stop showing the empty page on loading

Co-authored-by: Rafael Ferreira <[email protected]>
Co-authored-by: Tiago Evangelista Pinto <[email protected]>
Co-authored-by: Martin <[email protected]>
KevLehman added a commit that referenced this pull request Jul 20, 2021
…extual Bar (#22715)

* [IMPROVE][Enterprise] Create and Update CannedResponse API endpoints (#22151)

* createdBy query fix

* fix the canned-responses filter (#22207)

* fix Thread tslint error

* create .d.ts file to VerticalBar component

* rewrite Canned Responses contextual-bar components

* update fuselage version

* types for room.js

* create hooks for canned options and departments

* adjustments in cannedResponse contextual-bar

* adjustments in cannedResponse modal

* adjust in endpoints types

* adjust canned list

* adjust omnichanel canned response type definition

* add some new translations

* remove old stuff of cannedResponses

* [NEW] New components TextEditor and MarkdownTextEditor (#22173)

* Include Insert_Placeholder key

* change emojiPicker z-index

* create TextEditor component

* create MarkdownTextEditor component

* update fuselage dev version

* update fuselage and react-types version

* finish MardownTextEditorComponent

* update fuselage package

* modal with MarkdownTextEditor component

* reload component when edited

* fix form handle error

* add key prop

* create preview for MarkdownTextEditor

* remove canned-response contextual-bar from departments settings

* Use permissions instead of roles to check for canned responses

* Chore: added pagination to search msg endpoint (#22632)

* added pagination to search endpoint

* readded tests

* change livechat_enabled default value to true (#22697)

Co-authored-by: Leonardo Ostjen Couto <[email protected]>

* Add New and Edit with Data

* Use permissions instead of roles to check for canned responses

* New and edit pages

* Lint and removal of unused files

* fix lint

* FIX departments not working

* remove duplicate i18n key

* Misc improvements to canned responses endpoints

* Ts fixes

* more ts fixes

* use permission instead role

* Fix shortcut validation

* Fix shortcut validation

* Fix department & validation issues

* fix

Co-authored-by: Rafael Ferreira <[email protected]>
Co-authored-by: Rafael Ferreira <[email protected]>
Co-authored-by: Tiago Evangelista Pinto <[email protected]>
Co-authored-by: Kevin Aleman <[email protected]>
Co-authored-by: Leonardo Ostjen Couto <[email protected]>
KevLehman pushed a commit that referenced this pull request Jul 20, 2021
* Include Insert_Placeholder key

* change emojiPicker z-index

* create TextEditor component

* create MarkdownTextEditor component

* update fuselage dev version

* update fuselage and react-types version

* finish MardownTextEditorComponent

* update fuselage package
KevLehman pushed a commit that referenced this pull request Jul 20, 2021
#22190)

* no results components to table with no data

* [IMPROVE][Enterprise] Create and Update CannedResponse API endpoints (#22151)

* createdBy query fix

* fix the canned-responses filter (#22207)

* [NEW] New components TextEditor and MarkdownTextEditor (#22173)

* Include Insert_Placeholder key

* change emojiPicker z-index

* create TextEditor component

* create MarkdownTextEditor component

* update fuselage dev version

* update fuselage and react-types version

* finish MardownTextEditorComponent

* update fuselage package

* [NEW][ENTERPRISE] Canned responses Overview Page (#22623)

* [NEW] Empty page for Canned Responses Table

* FIX LGTM

* stop showing the empty page on loading

Co-authored-by: Rafael Ferreira <[email protected]>
Co-authored-by: Tiago Evangelista Pinto <[email protected]>
Co-authored-by: Martin <[email protected]>
KevLehman added a commit that referenced this pull request Jul 20, 2021
…extual Bar (#22715)

* [IMPROVE][Enterprise] Create and Update CannedResponse API endpoints (#22151)

* createdBy query fix

* fix the canned-responses filter (#22207)

* fix Thread tslint error

* create .d.ts file to VerticalBar component

* rewrite Canned Responses contextual-bar components

* update fuselage version

* types for room.js

* create hooks for canned options and departments

* adjustments in cannedResponse contextual-bar

* adjustments in cannedResponse modal

* adjust in endpoints types

* adjust canned list

* adjust omnichanel canned response type definition

* add some new translations

* remove old stuff of cannedResponses

* [NEW] New components TextEditor and MarkdownTextEditor (#22173)

* Include Insert_Placeholder key

* change emojiPicker z-index

* create TextEditor component

* create MarkdownTextEditor component

* update fuselage dev version

* update fuselage and react-types version

* finish MardownTextEditorComponent

* update fuselage package

* modal with MarkdownTextEditor component

* reload component when edited

* fix form handle error

* add key prop

* create preview for MarkdownTextEditor

* remove canned-response contextual-bar from departments settings

* Use permissions instead of roles to check for canned responses

* Chore: added pagination to search msg endpoint (#22632)

* added pagination to search endpoint

* readded tests

* change livechat_enabled default value to true (#22697)

Co-authored-by: Leonardo Ostjen Couto <[email protected]>

* Add New and Edit with Data

* Use permissions instead of roles to check for canned responses

* New and edit pages

* Lint and removal of unused files

* fix lint

* FIX departments not working

* remove duplicate i18n key

* Misc improvements to canned responses endpoints

* Ts fixes

* more ts fixes

* use permission instead role

* Fix shortcut validation

* Fix shortcut validation

* Fix department & validation issues

* fix

Co-authored-by: Rafael Ferreira <[email protected]>
Co-authored-by: Rafael Ferreira <[email protected]>
Co-authored-by: Tiago Evangelista Pinto <[email protected]>
Co-authored-by: Kevin Aleman <[email protected]>
Co-authored-by: Leonardo Ostjen Couto <[email protected]>
KevLehman added a commit that referenced this pull request Jul 21, 2021
* [IMPROVE][Enterprise] Create and Update CannedResponse API endpoints (#22151)

* [NEW] New components TextEditor and MarkdownTextEditor (#22173)

* Include Insert_Placeholder key

* change emojiPicker z-index

* create TextEditor component

* create MarkdownTextEditor component

* update fuselage dev version

* update fuselage and react-types version

* finish MardownTextEditorComponent

* update fuselage package

* [NEW][ENTERPRISE] Canned responses Overview Page (#22623)

* [IMPROVE] No results component for canned responses table with no data (#22190)

* no results components to table with no data

* [IMPROVE][Enterprise] Create and Update CannedResponse API endpoints (#22151)

* createdBy query fix

* fix the canned-responses filter (#22207)

* [NEW] New components TextEditor and MarkdownTextEditor (#22173)

* Include Insert_Placeholder key

* change emojiPicker z-index

* create TextEditor component

* create MarkdownTextEditor component

* update fuselage dev version

* update fuselage and react-types version

* finish MardownTextEditorComponent

* update fuselage package

* [NEW][ENTERPRISE] Canned responses Overview Page (#22623)

* [NEW] Empty page for Canned Responses Table

* FIX LGTM

* stop showing the empty page on loading

Co-authored-by: Rafael Ferreira <[email protected]>
Co-authored-by: Tiago Evangelista Pinto <[email protected]>
Co-authored-by: Martin <[email protected]>

* [NEW] NEW and EDIT pages for canned responses + Canned Responses Contextual Bar (#22715)

* [IMPROVE][Enterprise] Create and Update CannedResponse API endpoints (#22151)

* createdBy query fix

* fix the canned-responses filter (#22207)

* fix Thread tslint error

* create .d.ts file to VerticalBar component

* rewrite Canned Responses contextual-bar components

* update fuselage version

* types for room.js

* create hooks for canned options and departments

* adjustments in cannedResponse contextual-bar

* adjustments in cannedResponse modal

* adjust in endpoints types

* adjust canned list

* adjust omnichanel canned response type definition

* add some new translations

* remove old stuff of cannedResponses

* [NEW] New components TextEditor and MarkdownTextEditor (#22173)

* Include Insert_Placeholder key

* change emojiPicker z-index

* create TextEditor component

* create MarkdownTextEditor component

* update fuselage dev version

* update fuselage and react-types version

* finish MardownTextEditorComponent

* update fuselage package

* modal with MarkdownTextEditor component

* reload component when edited

* fix form handle error

* add key prop

* create preview for MarkdownTextEditor

* remove canned-response contextual-bar from departments settings

* Use permissions instead of roles to check for canned responses

* Chore: added pagination to search msg endpoint (#22632)

* added pagination to search endpoint

* readded tests

* change livechat_enabled default value to true (#22697)

Co-authored-by: Leonardo Ostjen Couto <[email protected]>

* Add New and Edit with Data

* Use permissions instead of roles to check for canned responses

* New and edit pages

* Lint and removal of unused files

* fix lint

* FIX departments not working

* remove duplicate i18n key

* Misc improvements to canned responses endpoints

* Ts fixes

* more ts fixes

* use permission instead role

* Fix shortcut validation

* Fix shortcut validation

* Fix department & validation issues

* fix

Co-authored-by: Rafael Ferreira <[email protected]>
Co-authored-by: Rafael Ferreira <[email protected]>
Co-authored-by: Tiago Evangelista Pinto <[email protected]>
Co-authored-by: Kevin Aleman <[email protected]>
Co-authored-by: Leonardo Ostjen Couto <[email protected]>

Co-authored-by: Rafael Ferreira <[email protected]>
Co-authored-by: Tiago Evangelista Pinto <[email protected]>
Co-authored-by: Rafael Ferreira <[email protected]>
Co-authored-by: Kevin Aleman <[email protected]>
Co-authored-by: Leonardo Ostjen Couto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants