Chore: Check PR Title on every submission #22140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevLehman
changed the title
KevLehman
changed the title
ggazzo
previously requested changes
May 27, 2021
ggazzo
changed the title
ggazzo
reviewed
May 27, 2021
ggazzo
changed the title
ggazzo
changed the title
Member
|
@pierre-lehnen-rc might want to give his opinion here as we have been discussing not using |
Member
|
I think we have been using this definition for a long time and modifying it in action it is easy, the discussion to find another term can take some time and generate changes in the documentation, in the meantime I think we should already be using validation |
Member
Author
|
I agree with Gazzo on that. We can defer the discussion about the new term, and start validating the new PRs. |
ggazzo
previously approved these changes
May 28, 2021
sampaiodiego
requested changes
May 28, 2021
sampaiodiego
approved these changes
Jun 14, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
We just need to define the list of Prefixes to use, and if we will do any other validation (the action supports using regexes to validate PR titles, but, i don't think we need it 😬)