Skip to content

[IMPROVE] Add debouncing to units selects filters #22097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renatobecker merged 2 commits into from
May 31, 2021
Merged

[IMPROVE] Add debouncing to units selects filters #22097

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9898fe6
[IMPROVE] Add debouncing to units selects filters
MartinSchoeler May 20, 2021
e5de411
Merge branch 'develop' into debounce_units
renatobecker May 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions ee/client/omnichannel/units/UnitEdit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
Select,
Margins,
} from '@rocket.chat/fuselage';
import { useMutableCallback } from '@rocket.chat/fuselage-hooks';
import { useMutableCallback, useDebouncedValue } from '@rocket.chat/fuselage-hooks';
import React, { useMemo, useState } from 'react';

import VerticalBar from '../../../../client/components/VerticalBar';
Expand All @@ -25,18 +25,26 @@ function UnitEdit({ data, unitId, isNew, unitMonitors, unitDepartments, reload,
const t = useTranslation();
const unitsRoute = useRoute('omnichannel-units');
const [monitorsFilter, setMonitorsFilter] = useState('');

const debouncedMonitorsFilter = useDebouncedValue(monitorsFilter, 500);

const [departmentsFilter, setDepartmentsFilter] = useState('');

const debouncedDepartmentsFilter = useDebouncedValue(departmentsFilter, 500);

const { itemsList: monitorsList, loadMoreItems: loadMoreMonitors } = useMonitorsList(
useMemo(() => ({ filter: monitorsFilter }), [monitorsFilter]),
useMemo(() => ({ filter: debouncedMonitorsFilter }), [debouncedMonitorsFilter]),
);

const { phase: monitorsPhase, items: monitorsItems, itemCount: monitorsTotal } = useRecordList(
monitorsList,
);

const { itemsList: departmentsList, loadMoreItems: loadMoreDepartments } = useDepartmentsList(
useMemo(() => ({ filter: departmentsFilter, unitId }), [departmentsFilter, unitId]),
useMemo(() => ({ filter: debouncedDepartmentsFilter, unitId }), [
debouncedDepartmentsFilter,
unitId,
]),
);

const {
Expand Down Expand Up @@ -173,7 +181,7 @@ function UnitEdit({ data, unitId, isNew, unitMonitors, unitDepartments, reload,
<Field.Label>{t('Departments')}*</Field.Label>
<Field.Row>
<PaginatedMultiSelectFiltered
filter={departmentsFilter}
filter={debouncedDepartmentsFilter}
setFilter={setDepartmentsFilter}
options={departmentsItems}
value={departments}
Expand All @@ -194,7 +202,7 @@ function UnitEdit({ data, unitId, isNew, unitMonitors, unitDepartments, reload,
<Field.Label>{t('Monitors')}*</Field.Label>
<Field.Row>
<PaginatedMultiSelectFiltered
filter={monitorsFilter}
filter={debouncedMonitorsFilter}
setFilter={setMonitorsFilter}
options={monitorsItems}
value={monitors}
Expand Down