Skip to content

Conversation

@rafaelblink
Copy link
Contributor

@rafaelblink rafaelblink commented May 20, 2021

Proposed changes (including videos or screenshots)

Deletion button has been removed from the edition option.

Before

image

After

Rocket Chat (2)

Issue(s)

Steps to test or reproduce

Further comments

@rafaelblink rafaelblink changed the title Remove canned responses button on edit form [FIX[EE] Canned responses can't be deleted May 20, 2021
@RocketChat RocketChat deleted a comment from CLAassistant May 20, 2021
@RocketChat RocketChat deleted a comment from CLAassistant May 20, 2021
@rafaelblink rafaelblink marked this pull request as ready for review May 20, 2021 23:05
@rafaelblink rafaelblink requested a review from a team May 20, 2021 23:06
@rafaelblink rafaelblink changed the title [FIX[EE] Canned responses can't be deleted [FIX][EE] Canned responses can't be deleted May 20, 2021
Copy link
Contributor

@renatobecker renatobecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deletion process works fine, but the button is placed on the CannedResponsesForm form and the right place is CannedResponseDetails.

@renatobecker renatobecker merged commit 2d25c42 into develop May 31, 2021
@renatobecker renatobecker deleted the omnichannel/remove-button-canned branch May 31, 2021 17:38
@sampaiodiego sampaiodiego mentioned this pull request Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants