[FIX] Web navigation breaks after visiting integrations admin page #21983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csranasinghe
changed the title
Contributor
Author
|
@gabriellsh can you please review this PR. |
dougfabris
approved these changes
May 27, 2021
dougfabris
added
the
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fix the navigation breaks issue after visiting the integrations administration page
Issue(s)
Fixes #21972
Steps to test or reproduce
Further comments
There was a not used useEffect hook which breaks the navigation of the whole app(Check below-highlighted code segment in client/views/admin/integrations/IntegrationsPage.js file). Removed that part from the code and tested the navigation.