Skip to content

[FIX] Missing proper permissions on Teams Channels #21946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 2 commits into from
May 12, 2021
Merged

[FIX] Missing proper permissions on Teams Channels #21946

ggazzo merged 2 commits into from
May 12, 2021

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented May 4, 2021 •
edited
Loading

Proposed changes (including videos or screenshots)

Issue(s)

Closes #21595

Steps to test or reproduce

  • Create a team
  • Add channels to the team
  • Check the permissions as a not-allowed user

Further comments

@dougfabris dougfabris requested a review from a team May 4, 2021 20:09
@yash-rajpal
Copy link
Member

yash-rajpal commented May 4, 2021

Hey @dougfabris !
I already have a PR #21591 which adds add-team-channel permission check to the Team channel contextual bar. Please have a look at that. :)

Thanks.

@dougfabris
Copy link
Member Author

dougfabris commented May 4, 2021 •
edited
Loading

Oh, awesome @yash-rajpal I didn't realize your PR! I'll remove add-team-channel to move forward with yours.
Thanks for the help =)

@yash-rajpal
Copy link
Member

yash-rajpal commented May 4, 2021

You are awesome! :)

Thanks.

@dougfabris dougfabris mentioned this pull request May 5, 2021
Closed
@dougfabris dougfabris linked an issue May 5, 2021 that may be closed by this pull request
Irrelevant display of 3 dots options in channel item of teams #21595
Closed
@yash-rajpal yash-rajpal mentioned this pull request May 7, 2021
Closed
@ggazzo ggazzo merged commit e55a7a7 into develop May 12, 2021
@ggazzo ggazzo deleted the fix/permission-add-teams branch May 12, 2021 12:37
@sampaiodiego sampaiodiego mentioned this pull request May 28, 2021
Merged
@dougfabris dougfabris mentioned this pull request Nov 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Irrelevant display of 3 dots options in channel item of teams

4 participants

@dougfabris @yash-rajpal @ggazzo