Skip to content

Conversation

@PriyaBihani
Copy link
Contributor

@PriyaBihani PriyaBihani commented Apr 29, 2021

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Earlier user could change its password without confirming it, this PR resolves this issue.

Previously
Password could be changed without confirmation

Now

Password change can not happen without confirming the new password

Issue(s)

Closes #21857

Further comments

@PriyaBihani
Copy link
Contributor Author

PriyaBihani commented Apr 29, 2021

@tiagoevanp @gabriellsh can you review :)

@tiagoevanp tiagoevanp requested a review from a team April 29, 2021 18:25
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but gives the user no visual feedback and can create confusion. You might want to take a look at the checks at client/views/account/AccountProfileForm.js:93. I think that's the real problem.

@PriyaBihani
Copy link
Contributor Author

This works, but gives the user no visual feedback and can create confusion. You might want to take a look at the checks at client/views/account/AccountProfileForm.js:93. I think that's the real problem.

Hey Gabriel, i've added some checks that gives a visual of what's happening, can you take a look :)

@PriyaBihani PriyaBihani requested a review from gabriellsh May 3, 2021 07:35
@PriyaBihani
Copy link
Contributor Author

@gabriellsh can you review ?

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021

CLA assistant check
All committers have signed the CLA.

@dougfabris
Copy link
Member

Hi there, thanks for the contribution! 🚀 💯

Closing this PR because it's duplicated now and it has been fixed in another one. #30306


Questions? Help needed? Feature Requests?

  • Join our Open Server in the #support channel and feel free to raise a question
  • Join our Community Forum and search/create a post there

@dougfabris dougfabris closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change password doesn't work as expected

5 participants