Skip to content

Conversation

@im-adithya
Copy link
Contributor

@im-adithya im-adithya commented Apr 27, 2021

Proposed changes (including videos or screenshots)

This was causing build failures so I have disabled eslint.

Issue(s)

Steps to test or reproduce

Further comments

@im-adithya
Copy link
Contributor Author

@MartinSchoeler Please review this :)

@yash-rajpal
Copy link
Member

@im-adithya I am not sure, but I think #21831 solves the lint issues on CI checks.

@im-adithya
Copy link
Contributor Author

No @yash-rajpal, this doesn't apply to CI checks but covers it (as it includes linting tests) and this PR disables eslint for the specific file.

@yash-rajpal
Copy link
Member

Yes, was just confirming it.

Also if you would do npm install in EE folder too, I don't think lint would give import errors on these files.

EE folder also now requires node modules.

@KevLehman
Copy link
Member

As @yash-rajpal mentioned, in local you should run npm install from the ee folder. Disabling eslint is not something we should do 😬

I'm closing this since it's not needed.

@KevLehman KevLehman closed this Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants