Skip to content

Fix: Missing module eventemitter3 for micro services #21611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sampaiodiego merged 2 commits into from
Apr 16, 2021
Merged

Fix: Missing module eventemitter3 for micro services #21611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66e7a6d
Fix: Missing module `eventemitter3` for micro services
rodrigok Apr 16, 2021
f9ea710
Fix micro services docker latest tag generation
rodrigok Apr 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/build_and_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,3 +595,14 @@ jobs:
docker build --build-arg SERVICE=${{ matrix.service }} -t rocketchat/${{ matrix.service }}-service:${IMAGE_TAG} .

docker push rocketchat/${{ matrix.service }}-service:${IMAGE_TAG}

if [[ $GITHUB_REF == refs/tags/* ]]; then
if echo "$GIT_TAG" | grep -Eq '^[0-9]+\.[0-9]+\.[0-9]+$' ; then
RELEASE="latest"
elif echo "$GIT_TAG" | grep -Eq '^[0-9]+\.[0-9]+\.[0-9]+-rc\.[0-9]+$' ; then
RELEASE="release-candidate"
fi

docker tag rocketchat/${{ matrix.service }}-service:${IMAGE_TAG} rocketchat/${{ matrix.service }}-service:${RELEASE}
docker push rocketchat/${{ matrix.service }}-service:${RELEASE}
fi
8 changes: 7 additions & 1 deletion ee/server/services/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion ee/server/services/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@
"nats": "^1.4.8",
"underscore.string": "^3.3.5",
"uuid": "^7.0.3",
"ws": "^7.2.3"
"ws": "^7.2.3",
"eventemitter3": "^4.0.7"
},
"devDependencies": {
"@types/ejson": "^2.1.2",
Expand Down