[FIX] Too many request on loadHistory method #21594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriellsh
changed the title
KevLehman
previously approved these changes
Apr 19, 2021
sampaiodiego
requested changes
Apr 20, 2021
sampaiodiego
previously requested changes
Apr 23, 2021
| typeName = (curRoomDoc ? curRoomDoc.t : undefined) + (curRoomDoc ? curRoomDoc.name : undefined); | ||
| } | ||
|
|
||
| // const showMessageInMainThread = getUserPreference(Meteor.userId(), 'showMessageInMainThread', false); |
Member
There was a problem hiding this comment.
I will, just commented to let you fetch all messages instead.
ggazzo
reviewed
Apr 23, 2021
ggazzo
reviewed
Apr 23, 2021
Co-authored-by: Diego Sampaio <[email protected]>
ggazzo
previously approved these changes
Apr 23, 2021
|
This pull request introduces 2 alerts when merging 96bac7b into a3656b3 - view on LGTM.com new alerts:
|
ggazzo
approved these changes
Apr 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Create one thread with ~1000 responses (without checking the "Also send to channel" box).
The user preference "Show thread messages on main thread" must be off.
Further comments