Skip to content

Conversation

@KevLehman
Copy link
Member

Proposed changes (including videos or screenshots)

  • Create new MediaService (ideally, should be in charge of all media-related operations)
  • Resize emojis to 128x128

Issue(s)

Steps to test or reproduce

Further comments

Add property to avoid resizing if the image is already smaller than target size
@KevLehman KevLehman requested review from a team and diegolmello April 16, 2021 19:20
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea having a service for this 👏

to make use of it's full potential though we need to make sure it works when using a network transporter (when using microservices on EE).. looks like moleculer supports ot (https://moleculer.services/docs/0.14/actions.html#Streaming) , so might be just a matter of testing it out :D

@KevLehman
Copy link
Member Author

I haven't tried running it as a ee microservice, but yeah, moleculer supports streams/buffers to be sent so we shouldn't have a big issue 😬

The other comments were resolved too.

@sampaiodiego sampaiodiego changed the title Resize emojis on upload instead of saving at max res [IMPROVE] Resize custom emojis on upload instead of saving at max res Apr 20, 2021
@sampaiodiego sampaiodiego merged commit c6b7e4f into develop Apr 20, 2021
@sampaiodiego sampaiodiego deleted the fix/resize-emojis branch April 20, 2021 21:03
@sampaiodiego sampaiodiego mentioned this pull request Apr 28, 2021
@antoine-roux
Copy link

Hello,
We should have an option to upload them at full-res.

I used to set some CSS to resize standalone emojis to make them appear like stickers:

span.emoji.big {
  width: 400px;
  height: 400px;
}

With this PR, I'm very sad because my stickers are very pixelated!
Antoine

@sampaiodiego
Copy link
Member

I'm sorry @antoine-roux this got hidden in the release notes, but we have increased the emoji size to 512x512 here.. hope that works for everyone =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants