[FIX] Fix the wrong user priviledges for on the UI for MovingToTeam & ConvertToTeam buttons #21587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating the code
updating the code
updating the fork
update main branch
updating the branch
Update fork
Upating the fork
Contributor
Author
|
@dougfabris can you review please ? :) |
Jeanstaquet
changed the title
Contributor
Author
|
Hi @KevLehman, can you review plsease ? :) |
dougfabris
approved these changes
Apr 29, 2021
Member
@Jeanstaquet Thanks for helping us! We really appreciate your contribution and we would love to be quicker on the reviews, but as you can see there's a lot of work here! Please, don't mention each member of the core team, it can confuse us! Thanks =) |
dougfabris
added
the
stat: ready to merge
Contributor
Author
|
@dougfabris Thanks for reviewing my PR, I will only mention one person from now on, thanks for the notice. 👍 |
Member
will be fixed here: #22350 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
I added the right privilege to not display AddToTeam and ConvertToTeam for those who can't
Before the changes
2021-04-15.18-49-12.mp4
After the changes
2021-04-15.19-01-21.mp4
Issue(s)
Fixes #21584
Steps to test or reproduce
Further comments