Regression: React + Blaze reconciliation #21567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging b85986e into da6b34f - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging b7d0e8b into 7f2d924 - view on LGTM.com new alerts:
|
…Chat into regression/reactivity
tiagoevanp
reviewed
Apr 15, 2021
|
|
||
| if (!previousNode) { | ||
| setTimeout(() => { | ||
| currentNode.dispatchEvent(new CustomEvent('MessageGroup', { bubbles: true })); |
tiagoevanp
reviewed
Apr 15, 2021
tiagoevanp
reviewed
Apr 15, 2021
tiagoevanp
reviewed
Apr 15, 2021
tiagoevanp
reviewed
Apr 15, 2021
| @@ -1,5 +1,5 @@ | |||
| import { Meteor } from 'meteor/meteor'; | |||
| import { Session } from 'meteor/session'; | |||
| // import { Session } from 'meteor/session'; | |||
tiagoevanp
reviewed
Apr 15, 2021
| name: roomConfig.route.name, | ||
| action: roomConfig.route.action, | ||
| triggersExit: [() => Session.set('openedRoom', '')], | ||
| // triggersExit: [() => Session.set('openedRoom', '')], |
tiagoevanp
reviewed
Apr 15, 2021
| @@ -1,5 +1,5 @@ | |||
| import { Blaze } from 'meteor/blaze'; | |||
| import { Session } from 'meteor/session'; | |||
| // import { Session } from 'meteor/session'; | |||
tiagoevanp
reviewed
Apr 15, 2021
|
|
||
| Session.set('lastOpenedRoom', Session.get('openedRoom')); | ||
| Session.set('openedRoom', null); | ||
| // Session.set('lastOpenedRoom', Session.get('openedRoom')); |
tiagoevanp
reviewed
Apr 15, 2021
| createTemplateForComponent( | ||
| 'DiscussionMetric', | ||
| () => import('./components/Message/Metrics/Discussion'), | ||
| { |
Contributor
There was a problem hiding this comment.
Code style consistence... braces in the same line or not?
Contributor
There was a problem hiding this comment.
Yep, under client/, Prettier is the ruler.
…Chat into regression/reactivity
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments