Skip to content

[FIX] Rename Omnichannel Rooms, Inquiries and Subscriptions when the Contact Name changes #21513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
renatobecker merged 10 commits into from
Apr 20, 2021
Merged

[FIX] Rename Omnichannel Rooms, Inquiries and Subscriptions when the Contact Name changes #21513

renatobecker merged 10 commits into from
Apr 20, 2021

Conversation

@rafaelblink
Copy link
Contributor

@rafaelblink rafaelblink commented Apr 9, 2021 •
edited
Loading

Proposed changes (including videos or screenshots)

Before

Rocket.Chat.2.mp4

After

Rocket.Chat.1.mp4

Issue(s)

Steps to test or reproduce

Further comments

@rafaelblink rafaelblink changed the title [FIX] Remove contact name from room edit form. [FIX] Omnichannel - Remove contact name from room edit form and update room name when contact name is changed. Apr 10, 2021
@rafaelblink rafaelblink marked this pull request as ready for review April 10, 2021 00:21
renatobecker
renatobecker requested changes Apr 12, 2021
View reviewed changes
@renatobecker renatobecker changed the title [FIX] Omnichannel - Remove contact name from room edit form and update room name when contact name is changed. [FIX] Rename Omnichannel Rooms, Inquiries and Subscriptions and the Contact Name changes Apr 12, 2021
@renatobecker renatobecker added this to the 3.14.0 milestone Apr 12, 2021
@renatobecker renatobecker changed the title [FIX] Rename Omnichannel Rooms, Inquiries and Subscriptions and the Contact Name changes [FIX] Rename Omnichannel Rooms, Inquiries and Subscriptions when the Contact Name changes Apr 12, 2021
renatobecker
renatobecker reviewed Apr 13, 2021
View reviewed changes
renatobecker
renatobecker requested changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@renatobecker renatobecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, except the Contact Name on the Room header.
That information is not being updated in real-time.

Screen Shot 2021-04-20 at 11 21 13 AM

@rafaelblink
Copy link
Contributor Author

rafaelblink commented Apr 20, 2021

Everything looks good, except the Contact Name on the Room header.
That information is not being updated in real-time.

Screen Shot 2021-04-20 at 11 21 13 AM

Rocket.Chat.1.mp4

I don't know which steps you did to not being updated but in this video is updated successfuly.

@renatobecker renatobecker merged commit 880546b into develop Apr 20, 2021
@renatobecker renatobecker deleted the omnichannel/refactor-name-contact-room branch April 20, 2021 20:57
@sampaiodiego sampaiodiego mentioned this pull request Apr 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@renatobecker renatobecker renatobecker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.14.0

Development

Successfully merging this pull request may close these issues.

3 participants

@rafaelblink @renatobecker