[FIX] Remove all agent subscriptions when an Omnichannel chat is closed #21509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
reviewed
Apr 9, 2021
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
@renatobecker two questions:
- any special reason to target this to a patch release? from what I understood it is been like this for a long time, seems like a regular fix to be on the next minor release;
- for those agents that stuck on the queue because their subscriptions were not removed, are you not planning to add a migration to clean their queues?
Contributor
Author
@sampaiodiego you're right, we can wait for the next minor release. |
Member
|
Great, thanks @renatobecker .. the current code looks good, waiting the migration for the final review :) |
Contributor
Author
@sampaiodiego I just submitted the migration file, this PR is no longer in draft mode. |
murtaza98
previously approved these changes
Apr 19, 2021
sampaiodiego
approved these changes
Apr 20, 2021
sampaiodiego
deleted the
omnichannel/remove-agent-subscriptions-after-closing-room
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an Omnichannel chat is closed the subscription of the agent who is serving the chat is removed, but other agents may join the conversation and, in that case, the subscriptions of other agents are not removed, hence, the chat gets stuck on their queues and prevent them from taking new chats in the queue.
Now, all room subscriptions will be removed as soon as the chat is closed.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments