Skip to content

Conversation

@Jeanstaquet
Copy link
Contributor

Proposed changes (including videos or screenshots)

The limit was calculated twice, which does not allow more threads to be loaded

Issue(s)

Fixes #21507

Steps to test or reproduce

2021-04-09.17-32-36.mp4

Further comments

@Jeanstaquet Jeanstaquet changed the title [FIX] Allows more than 25 threads to be loaded #21507 [FIX] Allows more than 25 threads to be loaded, fixes #21507 Apr 9, 2021
@Jeanstaquet
Copy link
Contributor Author

We have the same problems with user list, discussion list and file list. I take care of preparing the PR

Copy link
Member

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the fixes to the reactivity this PR seems to resolve the issue. It is loading the threads bit by bit fine

@MartinSchoeler MartinSchoeler added the stat: ready to merge PR tested and approved waiting for merge label Apr 19, 2021
@ggazzo ggazzo merged commit de37fb5 into RocketChat:develop Apr 20, 2021
gabriellsh added a commit that referenced this pull request Apr 20, 2021
…sChannelActions

* 'develop' of github.com:RocketChat/Rocket.Chat: (84 commits)
  [FIX] Margins on contextual bar information (#21457)
  [FIX] Allows more than 25 discussions/files to be loaded in the contextualbar (#21511)
  [FIX] Selected channels are not showing in Teams (#21669)
  Regression: Legacy Banner Position (#21598)
  [FIX] Remove size prop from StatusBullet component (#21428)
  [FIX] Audio message same pattern as image message (#21466)
  [FIX] Allows to display more than 25 users maximum in the users list (#21518)
  [FIX] Allows more than 25 threads to be loaded, fixes #21507 (#21508)
  [FIX] Use async await in TeamChannels delete channel action (#21534)
  [IMPROVE] Alert on team deletion (#21617)
  [FIX] Team types in admin -> rooms. (#21612)
  regression: Cannot enable e2e in direct room. (#21650)
  [FIX] Change team private info text (#21535)
  [FIX] Change margin size for quote messages (#21461)
  [FIX] Change the active appearance for toolbox buttons (#21416)
  [FIX] Team's channels list for teams with too many channels (#21491)
  [FIX] Rename team not working properly (#21552)
  Language update from LingoHub 🤖 (#21642)
  Fixes #21643 (#21644)
  Remove useless options at tabbar menu (#21561)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The threads list only displays a maximum of 25 threads

3 participants