-
Notifications
You must be signed in to change notification settings - Fork 13.1k
[FIX] Allows more than 25 threads to be loaded, fixes #21507 #21508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating the code
updating the code
updating the fork
update main branch
updating the branch
Update fork
Contributor
Author
|
We have the same problems with user list, discussion list and file list. I take care of preparing the PR |
MartinSchoeler
approved these changes
Apr 19, 2021
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the fixes to the reactivity this PR seems to resolve the issue. It is loading the threads bit by bit fine
gabriellsh
added a commit
that referenced
this pull request
Apr 20, 2021
…sChannelActions * 'develop' of github.com:RocketChat/Rocket.Chat: (84 commits) [FIX] Margins on contextual bar information (#21457) [FIX] Allows more than 25 discussions/files to be loaded in the contextualbar (#21511) [FIX] Selected channels are not showing in Teams (#21669) Regression: Legacy Banner Position (#21598) [FIX] Remove size prop from StatusBullet component (#21428) [FIX] Audio message same pattern as image message (#21466) [FIX] Allows to display more than 25 users maximum in the users list (#21518) [FIX] Allows more than 25 threads to be loaded, fixes #21507 (#21508) [FIX] Use async await in TeamChannels delete channel action (#21534) [IMPROVE] Alert on team deletion (#21617) [FIX] Team types in admin -> rooms. (#21612) regression: Cannot enable e2e in direct room. (#21650) [FIX] Change team private info text (#21535) [FIX] Change margin size for quote messages (#21461) [FIX] Change the active appearance for toolbox buttons (#21416) [FIX] Team's channels list for teams with too many channels (#21491) [FIX] Rename team not working properly (#21552) Language update from LingoHub 🤖 (#21642) Fixes #21643 (#21644) Remove useless options at tabbar menu (#21561) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The limit was calculated twice, which does not allow more threads to be loaded
Issue(s)
Fixes #21507
Steps to test or reproduce
2021-04-09.17-32-36.mp4
Further comments