[FIX] App installation from marketplace not correctly displaying the permissions #21470
Conversation
graywolf336
requested review from
d-gubert,
geekgonecrazy,
renatobecker and
thassiov
|
@rodrigok @sampaiodiego Urgent that this goes in with the release and any improvements you guys want done to it. Otherwise apps that have permisssion cannot be downloaded from the marketplace. |
|
@d-gubert not sure if this release has a bump in app engine version. But if not we need to some how bump that too so we can target apps in marketplace to this release and newer. |
Yeah we had the new Do you think we need a patch bump just for good measure? @geekgonecrazy |
Accepting suggestion from reviewer Co-authored-by: Diego Sampaio <[email protected]>
|
@geekgonecrazy @graywolf336 added the apps engine's patch |
d-gubert
force-pushed
the
fix-marketplace-app-installation-permissions
branch
from
49b7c35 to
d058933
Compare
d-gubert
dismissed
sampaiodiego’s stale review
Suggestion applied and test worked
sampaiodiego
changed the title
…permissions (#21470) Co-authored-by: Douglas Gubert <[email protected]> Co-authored-by: Diego Sampaio <[email protected]> Co-authored-by: thassiov <[email protected]>
Proposed changes (including videos or screenshots)
Fixes the marketplace app installation not correctly displaying the permissions modal.
Issue(s)
Steps to test or reproduce
Further comments