[IMPROVE] Add support to range downloads on file system storage #21463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevLehman
reviewed
Apr 6, 2021
| const range = getFileRange(file, req); | ||
| setRangeHeaders(range, file, res); | ||
|
|
||
| if (range) { |
Member
There was a problem hiding this comment.
The setRangeHeaders takes into consideration if range is out of bounds, but this condition does not. Maybe changing to range && !range.outOfRange?
Member
Author
There was a problem hiding this comment.
right.. I'll change to look more how GridFS does.. 👍
| res.setHeader('Content-Length', file.size); | ||
|
|
||
| this.store.getReadStream(file._id, file).pipe(res); | ||
| if (!options.hasOwnProperty('start')) { |
Member
There was a problem hiding this comment.
This may fail if { start: undefined } (cause the property is there, but with an invalid value).
KevLehman
reviewed
Apr 6, 2021
KevLehman
approved these changes
Apr 6, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Closes #20203
Related to RocketChat/Rocket.Chat.ReactNative#2759
Steps to test or reproduce
Further comments