Skip to content

[FIX] Wrong useMemo on Priorities EE field. #21453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renatobecker merged 4 commits into from
Apr 6, 2021
Merged

[FIX] Wrong useMemo on Priorities EE field. #21453

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
80e25e2
remove useless memo from priorities field.
rafaelblink Apr 5, 2021
986da70
undo e fix the deps array
rafaelblink Apr 5, 2021
73e4289
Merge branch 'develop' into omnichannel/useless-memo-priorities-selec…
renatobecker Apr 6, 2021
9079514
Merge branch 'develop' into omnichannel/useless-memo-priorities-selec…
renatobecker Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ee/client/omnichannel/additionalForms/PrioritiesSelect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React, { useMemo } from 'react';
import { Field, Select } from '@rocket.chat/fuselage';

export const PrioritiesSelect = ({ options, value, handler, label }) => {
const optionsSelect = useMemo(() => (options && options.length > 0) && options.map((option) => [option._id, option.name], [options]));
const optionsSelect = useMemo(() => (options && options.length > 0) && options.map((option) => [option._id, option.name]), [options]);

return <Field>
<Field.Label>{label}</Field.Label>
Expand Down