Skip to content

Conversation

@matheusbsilva137
Copy link
Contributor

@matheusbsilva137 matheusbsilva137 commented Apr 1, 2021

Proposed changes (including videos or screenshots)

  • Add support to queries (within the query parameter) in channels.members and groups.members endpoints.

Issue(s)

Task - ClickUp

Steps to test or reproduce

Example input (using cURL):

curl -G 'http://localhost:3000/api/v1/channels.members?roomId=vrdXhpY2BvB8R8MMF&status[]=offline&username=some.user' \
  -H 'X-Auth-Token: Dommgtm9xJefbcn7vyjVi2PbrM_Tk3SAnYl043qkflp' \
  -H 'X-User-Id: dizcH9Edm8hC7ziDX' \
  -H 'Content-Type: application/json'

Further comments

Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change this PR to make it similar to #21471 in terms of parameters accepted.. thx

Copy link
Member

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing that I think this is missing is support for search (by username, name, etc). But the basic support for the query params looks good :)

@sampaiodiego sampaiodiego changed the title Regression: Add support to queries in channels.members and groups.members endpoints [IMPROVE] Add support to queries in channels.members and groups.members endpoints May 13, 2021
@sampaiodiego sampaiodiego requested a review from KevLehman May 13, 2021 17:56
@sampaiodiego sampaiodiego merged commit 35b497c into develop May 14, 2021
@sampaiodiego sampaiodiego deleted the teams-back-groups-channels-queries branch May 14, 2021 13:43
@sampaiodiego sampaiodiego mentioned this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants