-
Notifications
You must be signed in to change notification settings - Fork 13.1k
[FIX] CORS error while interacting with any action button on Livechat #21406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ns on Livechat
|
It looks good to me, I'd just like to get the eyes of @sampaiodiego to check on the use of the Settings 🙂 |
|
the only issue I'm seeing is that if the settings are updated the new values are not read, so it would require a server restart to get updates CORS values. |
Thanks this was helpful! 😄 Done with this change |
sampaiodiego
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @murtaza98 the code looks better now, but while testing I was getting "Not allowed by CORS" even with CORS disabled and using from same domain (using from rocket.chat web client actually).
can you take a look on that pls? thx
Hey @sampaiodiego I was able to solve this issue by adding a new check there in callback |
|
hi @murtaza98 .. I tested it again and even with CORS disabled I'm not able to use |
|
Hey @sampaiodiego There was an issue within the condition over here due to which you were getting the error. I've now updated the logic to handle this. Request you to please review it again. Thanks! |
|
This pull request introduces 1 alert when merging 4134485 into 5120207 - view on LGTM.com new alerts:
|
|
Guys, Some of the builds are failing here and the error is not related to this PR. The error was being caused by some of the merge changes I made in this PR. Due to this, I decided to close this PR and create a new PR with only relevant change. NEW PR: #22121 |



Proposed changes (including videos or screenshots)
Issue(s)
#21033
Steps to test or reproduce
Further comments