[IMPROVE][APPS] Scheduler option to skip immediate execution of recurring jobs #21353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thassiov
changed the title
d-gubert
requested changes
Apr 6, 2021
d-gubert
requested changes
Apr 6, 2021
Contributor
Author
|
Depends on RocketChat/Rocket.Chat.Apps-engine#403 |
shiqimei
previously approved these changes
Apr 12, 2021
d-gubert
previously approved these changes
Apr 15, 2021
d-gubert
changed the title
d-gubert
approved these changes
Apr 21, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Create and schedule a task manually at
scheduleRecurringmethod so the first iteration runs after the configured interval. This is accomplished by adding the settingskipImmediate: truewhen setting up the task.Issue(s)
Steps to test or reproduce
Further comments
Added a lot of documentation and make the module log errors properly using the official logger