Regression: Room Edit form not rendering priority and custom fields #21309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatobecker
changed the title
renatobecker
changed the title
renatobecker
changed the title
renatobecker
requested changes
Mar 30, 2021
Contributor
renatobecker
left a comment
renatobecker
left a comment
There was a problem hiding this comment.
When I open the Room Edit form and I change custom fields, the Confirm button doesn't get enabled.
Also, there are other cases when I open the same for and the Confirm button is enabled by default.
We need to fix all these inconsistencies.
renatobecker
changed the title
Contributor
|
Also, when I run the server without an enterprise license I got the error displayed above. |
renatobecker
requested changes
Mar 31, 2021
client/omnichannel/directory/chats/contextualBar/ChatRoomForm.js
Outdated
Show resolved
Hide resolved
…ression' into omnichannel/inputs-edit-room-regression
renatobecker
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
After migration to the new
edit roomcomponent, some fields are wrong, this PR will show correct fields such ascustom fields (room scope),priority (EE), etc.Before
After
Issue(s)
Steps to test or reproduce
Further comments