Skip to content

[FIX] Discussions not showing in Safari #21270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 4 commits into from
Apr 23, 2021
Merged

[FIX] Discussions not showing in Safari #21270

ggazzo merged 4 commits into from
Apr 23, 2021

Conversation

@Kartik18g
Copy link
Contributor

@Kartik18g Kartik18g commented Mar 23, 2021

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Previously Discussions were not showing up in safari:
Screenshot 2021-03-23 at 7 58 42 PM

Now
Discussions show up as expected in safari:
Screenshot 2021-03-23 at 7 59 28 PM

Issue(s)

#21231

Steps to test or reproduce

Further comments

@Kartik18g Kartik18g changed the title [FIX] Percent (%) Discussions not showing in Safari #21231 [FIX] Discussions not showing in Safari Mar 24, 2021
@PriyaBihani PriyaBihani mentioned this pull request Mar 24, 2021
Closed
3 tasks
@tassoevan tassoevan requested a review from a team April 19, 2021 13:41
@tassoevan tassoevan added this to the 3.14.0 milestone Apr 19, 2021
@ggazzo ggazzo merged commit 5cc642d into RocketChat:develop Apr 23, 2021
gabriellsh added a commit that referenced this pull request Apr 23, 2021
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
dd91d16 
…bold

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Discussions not showing in Safari (#21270)
  Regression: Reconnection not working properly due to changes on ECHD Proxy (#21741)
  Regression: Fix scroll to bottom (#21731)
  [FIX] Toolbox icons order (#21739)
  Regression: Bold, italic and strike render (Original markdown) (#21747)
  Regression: Fix room not returning to the previous room after directory (#21757)
  Regression: Fix services Docker image build (#21750)
@sampaiodiego sampaiodiego mentioned this pull request Apr 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.14.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Kartik18g @ggazzo @tassoevan