Skip to content

Conversation

@murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Mar 22, 2021

Proposed changes (including videos or screenshots)

NOTE: This PR is to be merged after PR #20945 since it's built on top of it

Here we're handling following events which were getting impacted by this new on-hold feature

  • Returning chat to the queue
  • Forwarding chats
  • Closing chats

For each of the above events, we're making sure that recent changes to Routing mechanism for on-hold feature isn't changing the existing behaviour of these events.
Additionally we're making sure that if any of the above events are triggered from a chat which is already On Hold, then we cleanup all the OnHold chat related properties.

Issue(s)

Steps to test or reproduce

Further comments

…events

- Returning chat to the queue
- Forwarding chats
- Closing chats
@murtaza98 murtaza98 requested a review from renatobecker March 22, 2021 10:19
@murtaza98 murtaza98 changed the base branch from develop to omnichannel/on-hold March 22, 2021 10:19
@murtaza98 murtaza98 merged commit 8b8b9b9 into omnichannel/on-hold Mar 22, 2021
@murtaza98 murtaza98 deleted the omnichannel/on-hold-regression branch March 22, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants