[NEW] Quick action buttons for Omnichannel #21123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tons' into omnichannel/new-quick-action-buttons
ggazzo
requested changes
Mar 19, 2021
Member
ggazzo
left a comment
ggazzo
left a comment
There was a problem hiding this comment.
Beside my review there is some lint/LGTM issues to solve and please move from draft to ready to review if you believe the code is done to review.
whenever possible provide more info about what your changes stands for and if its possible provide some images from the result.
renatobecker
changed the title
renatobecker
requested changes
Mar 19, 2021
Co-authored-by: Renato Becker <[email protected]>
…tons' into omnichannel/new-quick-action-buttons
…tons' into omnichannel/new-quick-action-buttons
renatobecker
requested changes
Mar 19, 2021
ggazzo
requested changes
Mar 22, 2021
Member
ggazzo
left a comment
ggazzo
left a comment
There was a problem hiding this comment.
I could not see the actions rendered, maybe some fuselage icons is missing?
I you have plans to update fuselage, please use <Modal.Icon /> instead
renatobecker
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The purpose of this PR is to change to location of the actions buttons to the room header
Rocket.Chat.4.mp4
Issue(s)
Steps to test or reproduce
Further comments