Skip to content

[FIX] Allow deletion of own account for passwordless accounts (e.g. OAUTH) #21119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sampaiodiego merged 2 commits into from
Apr 21, 2021
Merged

[FIX] Allow deletion of own account for passwordless accounts (e.g. OAUTH) #21119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f317ee0
Fix check for username for deletion of own account
wolbernd Mar 15, 2021
9f41ea3
Merge branch 'develop' into develop
sampaiodiego Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/lib/server/methods/deleteUserOwnAccount.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Meteor } from 'meteor/meteor';
import { check } from 'meteor/check';
import { Accounts } from 'meteor/accounts-base';
import { SHA256 } from 'meteor/sha';
import s from 'underscore.string';

import { settings } from '../../../settings';
Expand Down Expand Up @@ -34,7 +35,7 @@ Meteor.methods({
if (result.error) {
throw new Meteor.Error('error-invalid-password', 'Invalid password', { method: 'deleteUserOwnAccount' });
}
} else if (user.username !== s.trim(password)) {
} else if (SHA256(user.username) !== s.trim(password)) {
throw new Meteor.Error('error-invalid-username', 'Invalid username', { method: 'deleteUserOwnAccount' });
}

Expand Down
1 change: 0 additions & 1 deletion client/views/account/AccountProfilePage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,6 @@ const AccountProfilePage = () => {
onCancel={closeModal}
title={title}
text={t('If_you_are_sure_type_in_your_username')}
isPassword
/>
));
}, [closeModal, deleteOwnAccount, dispatchToastMessage, erasureType, localPassword, t, setModal]);
Expand Down